Skip to content

EPD-2072: update dataset parser - #363

Merged
josorio-autoblocks merged 3 commits into
mainfrom
jose/epd-2072-update-sdks-to-support-default-value-and-add-safe-parse
Jun 25, 2025
Merged

EPD-2072: update dataset parser#363
josorio-autoblocks merged 3 commits into
mainfrom
jose/epd-2072-update-sdks-to-support-default-value-and-add-safe-parse

Conversation

@josorio-autoblocks

@josorio-autoblocks josorio-autoblocks commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the Python SDK's dataset schema system to support default values and improve schema property validation. Key points below:

  • Added default_value field in autoblocks/_impl/datasets/models/schema.py using Pydantic's Field with 'defaultValue' alias for API compatibility
  • Implemented field validation for schema properties in Dataset and DatasetSchema models with improved error handling
  • Added comprehensive test coverage in tests/autoblocks/test_app_client_datasets.py for default value handling and edge cases
  • Consider refactoring duplicate validation code between Dataset and DatasetSchema classes

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile

Comment thread tests/autoblocks/test_app_client_datasets.py Outdated
Comment thread autoblocks/_impl/datasets/models/dataset.py Outdated
@josorio-autoblocks
josorio-autoblocks merged commit a5b83cf into main Jun 25, 2025
6 checks passed
@josorio-autoblocks
josorio-autoblocks deleted the jose/epd-2072-update-sdks-to-support-default-value-and-add-safe-parse branch June 25, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants